fix(backup): Change UserIP relocation scope to global #68140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Apr 3, 2024
azaslavsky
added a commit
that referenced
this pull request
Apr 3, 2024
These had previously been increased in #68080 and again in #68120 to aid with debugging. Now that #68140 has addressed the root cause of these excessively long imports, we can bring these timeouts down to a more reasonable level. One benefit of the episode is that we now know how long it takes to import/export a ~50MB relocation file. Based on this, we've set the timeouts back to 5 minutes for tasks we expect to be quick (handling `baseline-config` and `colliding-user` steps), while increasing the timeouts for the actual relocation import/export steps to 40 minutes. Since even very large comparisons proved quite quick, we're lowering that timeout to 2 minutes.
azaslavsky
added a commit
that referenced
this pull request
Apr 3, 2024
These had previously been increased in #68080 and again in #68120 to aid with debugging. Now that #68140 has addressed the root cause of these excessively long imports, we can bring these timeouts down to a more reasonable level. One benefit of the episode is that we now know how long it takes to import/export a ~50MB relocation file. Based on this, we've set the timeouts back to 5 minutes for tasks we expect to be quick (handling `baseline-config` and `colliding-user` steps), while increasing the timeouts for the actual relocation import/export steps to 40 minutes. Since even very large comparisons proved quite quick, we're lowering that timeout to 2 minutes.
azaslavsky
added a commit
that referenced
this pull request
Apr 3, 2024
These had previously been increased in #68080 and again in #68120 to aid with debugging. Now that #68140 has addressed the root cause of these excessively long imports, we can bring these timeouts down to a more reasonable level. One benefit of the episode is that we now know how long it takes to import/export a ~50MB relocation file. Based on this, we've set the timeouts back to 5 minutes for tasks we expect to be quick (handling `baseline-config` and `colliding-user` steps), while increasing the timeouts for the actual relocation import/export steps to 40 minutes. Since even very large comparisons proved quite quick, we're lowering that timeout to 2 minutes.
shellmayr
pushed a commit
that referenced
this pull request
Apr 10, 2024
The comment I left in `UserIP` explains why this was necessary.
shellmayr
pushed a commit
that referenced
this pull request
Apr 10, 2024
These had previously been increased in #68080 and again in #68120 to aid with debugging. Now that #68140 has addressed the root cause of these excessively long imports, we can bring these timeouts down to a more reasonable level. One benefit of the episode is that we now know how long it takes to import/export a ~50MB relocation file. Based on this, we've set the timeouts back to 5 minutes for tasks we expect to be quick (handling `baseline-config` and `colliding-user` steps), while increasing the timeouts for the actual relocation import/export steps to 40 minutes. Since even very large comparisons proved quite quick, we're lowering that timeout to 2 minutes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment I left in
UserIPexplains why this was necessary.