ref(perf): Use span IDs instead of event IDs in samples table#68295
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Apr 4, 2024
0Calories
added a commit
that referenced
this pull request
Apr 9, 2024
Accidentally replaced a conditional in #68295 We were not checking for a `transaction_id` column, this PR puts it back in place so that the table can handle the case of linking to both a transaction ID and span ID
shellmayr
pushed a commit
that referenced
this pull request
Apr 10, 2024
Updates the samples table in the slideout panel to list span IDs instead of event IDs, since we are now focusing on a span-centric flow. The querying and linking works the same as before, we just opt to display the span ID in the table instead now. ### Before  ### After 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the samples table in the slideout panel to list span IDs instead of event IDs, since we are now focusing on a span-centric flow. The querying and linking works the same as before, we just opt to display the span ID in the table instead now.
Before
After