ref(rules): Add batch_query_hook to EventFrequencyCondition

[ceorourke]

Add a batch_query_hook to the EventFrequencyCondition so that when we process "slow" rule conditions we can batch the queries by group ids.

Partially closes https://github.com/getsentry/team-core-product-foundations/issues/239

[codecov]

Bundle Report

Changes will increase total bundle size by 93.75kB ⬆️

Bundle name	Size	Change
sentry-webpack-bundle-array-push	26.27MB	93.75kB ⬆️

[saponifi3d]

i think the biggest thing here is to make sure we can't do the queries in a single scan, since that has such a big impact on our goals for the project.

[saponifi3d]

Suggested change

	referrer_suffix="alert_event_frequency",
	referrer_suffix=referrer_suffix

[saponifi3d]

In javascript i'd generally define get_chunked_sums inside of the batch_query_hook function and then reference the start, end, and environment_id from the outer scope. Is that a faux pas in python? (if not, it might help DRY this code up a little more and reduce it by 9 more lines 😎)

It'd be something like:

def get_chunked_sums(groups: list[Group], referrer_suffix: str):
    # same code you have for get_chunked_sums

if error_issues:
    error_sums = get_chunked_sums(
        groups=error_issues,

        # looks like referrer_suffix could be DRY'd up and hardcoded in get_chunked_sums as well
        referrer_suffix="alert_event_frequency"
    )

[saponifi3d]

🎉

[saponifi3d]

lgtm once we either dry the code up or update the param 🎉

[sentry]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ProcessingErrorInvalidTransaction: invalid transaction event: end timestamp is smaller than start timestamp pytest.runtest.protocol tests/snuba/rules/condi... View Issue

_{Did you find this useful? React with a 👍 or 👎}