ref(rules): Add batch_query_hook to EventFrequencyPercentCondition#68765
Conversation
github-actions
Bot
added
the
Scope: Backend
| percent_intervals[self.get_option("interval")][1].total_seconds() // 60 | ||
| ) | ||
| avg_sessions_in_interval = session_count_last_hour / (60 / interval_in_minutes) | ||
| error_issues = [ |
There was a problem hiding this comment.
Just calling out that I'm fairly certain this condition only applies to error issues, so I just pulled those one so we're not attempting to query snuba on other issues that are definitely going to return 0 and is useless data.
There was a problem hiding this comment.
nice, is there anything we should do to ensure this only goes to error issues?
There was a problem hiding this comment.
I think this should be sufficient, I guess we could pull them out before calling this but it doesn't really matter.
Bundle ReportChanges will increase total bundle size by 1.31kB ⬆️
|
| percent_intervals[self.get_option("interval")][1].total_seconds() // 60 | ||
| ) | ||
| avg_sessions_in_interval = session_count_last_hour / (60 / interval_in_minutes) | ||
| error_issues = [ |
There was a problem hiding this comment.
nice, is there anything we should do to ensure this only goes to error issues?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
2 participants
Another follow up to #68672 and a part 3 of https://github.com/getsentry/team-core-product-foundations/issues/239 to add a batch_query_hook function for the EventFrequencyPercentCondition.