fix(replays): Shorten storage policy retry cadence#68786
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
bruno-garcia
approved these changes
Apr 12, 2024
c298lee
pushed a commit
that referenced
this pull request
Apr 12, 2024
Shortens the storage policy retry length from 17 seconds to 1.7 seconds. Currently we wait 250 milliseconds after the first failure. This is probably too long. A 10x decrease in the wait time is roughly the amount of time it takes to upload a file in the first place. Waiting one upload interval and checking the service provider again seems reasonable. We also don't want to block the process for 17 seconds. Let's block for ~1.7 and if it hasn't fixed it self do our normal crash and retry cycle. The goal is to not allow random or intermittent failures to significantly lower throughput when we could immediately retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortens the storage policy retry length from 17 seconds to 1.7 seconds. Currently we wait 250 milliseconds after the first failure. This is probably too long. A 10x decrease in the wait time is roughly the amount of time it takes to upload a file in the first place. Waiting one upload interval and checking the service provider again seems reasonable. We also don't want to block the process for 17 seconds. Let's block for ~1.7 and if it hasn't fixed it self do our normal crash and retry cycle.
The goal is to not allow random or intermittent failures to significantly lower throughput when we could immediately retry.