feat(trace): bring back dashed backgrounds#69321
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
JonasBa
force-pushed
the
jb/trace/queries-buttons
branch
from
c3b56c8 to
a8bf749
Compare
JonasBa
force-pushed
the
jb/trace/queries-buttons
branch
from
a8bf749 to
8519cdc
Compare
Bundle ReportChanges will increase total bundle size by 17.12kB ⬆️
|
JonasBa
force-pushed
the
jb/trace/queries-buttons
branch
from
8519cdc to
f65395d
Compare
JonasBa
force-pushed
the
jb/trace/queries-buttons
branch
from
f65395d to
9bb432d
Compare
JonasBa
commented
Apr 23, 2024
| }); | ||
|
|
||
| for (let i = 0; i < this.columns.list.column_refs.length; i++) { | ||
| const span_bar = this.span_bars[i]; |
Contributor
Author
There was a problem hiding this comment.
All of these methods got consolidated into the appropriate drawXXX calls, hence why the diff got huge. It was unmaintainable to keep them all inline
Abdkhan14
approved these changes
Apr 23, 2024
armenzg
pushed a commit
that referenced
this pull request
Apr 24, 2024
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.