fix(replays): dont let superusers affect viewed by#69529
Merged
Conversation
JoshFerge
commented
Apr 23, 2024
JoshFerge
commented
Member
- dont show superusers user_ids in the viewed by response
- Don't create a viewed by record if the user is not in the org of the replay
github-actions
Bot
added
the
Scope: Backend
michellewzhang
approved these changes
Apr 23, 2024
c298lee
approved these changes
Apr 23, 2024
billyvg
approved these changes
Apr 23, 2024
armenzg
pushed a commit
that referenced
this pull request
Apr 24, 2024
- dont show superusers user_ids in the viewed by response - Don't create a viewed by record if the user is not in the org of the replay
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
- dont show superusers user_ids in the viewed by response - Don't create a viewed by record if the user is not in the org of the replay
Member
|
Linking #64924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.