feat(javascript): Handle TypeScript module name detection#7048
Merged
kamilogorek merged 1 commit intomasterfrom Jan 26, 2018
Merged
feat(javascript): Handle TypeScript module name detection#7048kamilogorek merged 1 commit intomasterfrom
kamilogorek merged 1 commit intomasterfrom
Conversation
Contributor
|
I honestly feel like we might just generate the module no matter what and chop off the tail ext. |
kamilogorek
force-pushed
the
typescript-modules
branch
from
517640e to
b8384d2
Compare
mitsuhiko
approved these changes
Jan 26, 2018
mitsuhiko
suggested changes
Jan 26, 2018
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
We still need to handle the .min case.
mitsuhiko
approved these changes
Jan 26, 2018
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
Ignore me. I need coffee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it so instead of seeing
people will see actual module name.