ref(cogs): Remove and sample logs for dynamic sampling and on demand metrics#70718
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70718 +/- ##
==========================================
+ Coverage 78.02% 80.02% +1.99%
==========================================
Files 6505 6504 -1
Lines 290761 290685 -76
Branches 50108 50095 -13
==========================================
+ Hits 226864 232617 +5753
+ Misses 63458 57631 -5827
+ Partials 439 437 -2
|
obostjancic
approved these changes
May 13, 2024
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of the logging which was in on demand metrics extraction and dynamic sampling. Most of that logging was super helpful in quickly debugging problems with both systems but considering the cost, it might be just easier to add them back only when investigating problems (since we didn't access those logs very often).
For logs that are important to have, I decided to sample them at 10% and this includes the log for the extrapolated volume and sample rate used in dynamic sampling.