Skip to content

ref(cogs): Remove and sample logs for dynamic sampling and on demand metrics#70718

Merged
iambriccardo merged 5 commits into
masterfrom
riccardo/ref/cleanup-logs
May 13, 2024
Merged

ref(cogs): Remove and sample logs for dynamic sampling and on demand metrics#70718
iambriccardo merged 5 commits into
masterfrom
riccardo/ref/cleanup-logs

Conversation

@iambriccardo

@iambriccardo iambriccardo commented May 13, 2024

Copy link
Copy Markdown
Contributor

This PR removes a lot of the logging which was in on demand metrics extraction and dynamic sampling. Most of that logging was super helpful in quickly debugging problems with both systems but considering the cost, it might be just easier to add them back only when investigating problems (since we didn't access those logs very often).

For logs that are important to have, I decided to sample them at 10% and this includes the log for the extrapolated volume and sample rate used in dynamic sampling.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2024
@iambriccardo iambriccardo changed the title riccardo/ref/cleanup logs ref(cogs): Remove and sample logs for dynamic sampling and on demand metrics May 13, 2024
@iambriccardo iambriccardo marked this pull request as ready for review May 13, 2024 08:59
@iambriccardo iambriccardo requested a review from a team as a code owner May 13, 2024 08:59
@codecov

codecov Bot commented May 13, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.02%. Comparing base (54b7473) to head (6a4dc2b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70718      +/-   ##
==========================================
+ Coverage   78.02%   80.02%   +1.99%     
==========================================
  Files        6505     6504       -1     
  Lines      290761   290685      -76     
  Branches    50108    50095      -13     
==========================================
+ Hits       226864   232617    +5753     
+ Misses      63458    57631    -5827     
+ Partials      439      437       -2     
Files Coverage Δ
src/sentry/dynamic_sampling/__init__.py 100.00% <ø> (ø)
src/sentry/dynamic_sampling/rules/base.py 91.48% <ø> (-0.35%) ⬇️
...ynamic_sampling/tasks/boost_low_volume_projects.py 93.22% <100.00%> (+32.38%) ⬆️
...ic_sampling/tasks/boost_low_volume_transactions.py 96.72% <100.00%> (-0.02%) ⬇️
src/sentry/dynamic_sampling/tasks/collect_orgs.py 47.82% <ø> (+1.67%) ⬆️
src/sentry/dynamic_sampling/tasks/common.py 93.97% <100.00%> (+10.03%) ⬆️
...ynamic_sampling/tasks/custom_rule_notifications.py 61.84% <100.00%> (-1.45%) ⬇️
src/sentry/dynamic_sampling/tasks/logging.py 66.66% <ø> (-6.31%) ⬇️
src/sentry/dynamic_sampling/tasks/utils.py 97.22% <100.00%> (-0.22%) ⬇️
src/sentry/relay/config/metric_extraction.py 91.96% <100.00%> (-0.10%) ⬇️
... and 1 more

... and 486 files with indirect coverage changes

@iambriccardo iambriccardo merged commit 7be978d into master May 13, 2024
@iambriccardo iambriccardo deleted the riccardo/ref/cleanup-logs branch May 13, 2024 10:57
@sentry

sentry Bot commented May 14, 2024

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ QueryExecutionError: DB::Exception: Received from snuba-generic-metrics-1-3:9000. DB::Exception: default: Authenticati... sentry.dynamic_sampling.tasks.boost_low_volume_... View Issue
  • ‼️ QueryExecutionError: DB::Exception: Received from snuba-generic-metrics-1-3:9000. DB::Exception: default: Authenticati... sentry.dynamic_sampling.tasks.recalibrate_orgs View Issue
  • ‼️ QueryExecutionError: DB::Exception: Received from snuba-generic-metrics-1-3:9000. DB::Exception: default: Authenticati... sentry.dynamic_sampling.tasks.boost_low_volume_... View Issue

Did you find this useful? React with a 👍 or 👎

@sentry

sentry Bot commented May 21, 2024

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SnubaError: HTTPConnectionPool(host='127.0.0.1', port=10006): Read timed out. (read timeout=30) sentry.dynamic_sampling.tasks.boost_low_volume_... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants