ref: replace legacy keys with canonical keys in samples#70752
Conversation
github-actions
Bot
added
the
Scope: Backend
asottile-sentry
force-pushed
the
asottile-canonical-key-in-samples
branch
from
ee304c7 to
22a9758
Compare
asottile-sentry
changed the title
asottile-sentry
force-pushed
the
asottile-canonical-key-in-samples
branch
from
22a9758 to
beef0d9
Compare
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
(I didn't check usages in the code, yet) Are these samples used in tests? I'm asking as IIRC at least message is still used by SDKs and is documented as a valid key. We could fix such tests by running the payload through librelay's normalize function, if that's the case.
they're used in tests and I believe public samples -- they are injected directly into eventstore in tests which I believe is why they're triggering canonical rewriting there -- (the canonical rewriting just makes the |
asottile-sentry
force-pushed
the
asottile-canonical-key-in-samples
branch
from
beef0d9 to
e12d62f
Compare
| "dist": null, | ||
| "platform": "csharp", | ||
| "culprit": "Samples.AspNetCore.Mvc.Controllers.HomeController in PostIndex", | ||
| "message": "Param is null!", |
There was a problem hiding this comment.
this was duplicated below as logentry already
| "dist": "2", | ||
| "platform": "java", | ||
| "message": "", | ||
| "logentry": {}, |
There was a problem hiding this comment.
Shouldn't the empty ones be removed?
There was a problem hiding this comment.
I think these are intentional to avoid the code which injects a default message here so I left them
| "culprit": "script-src 'self' 'unsafe-eval' 'unsafe-inline' www.example.com", | ||
| "message": "Blocked 'script' from 'example.org'", | ||
| "sentry.interfaces.Csp": { | ||
| "logentry": {"formatted": "Blocked 'script' from 'example.org'"}, |
There was a problem hiding this comment.
nit:
| "logentry": {"formatted": "Blocked 'script' from 'example.org'"}, | |
| "logentry": { | |
| "formatted": "Blocked 'script' from 'example.org'" | |
| }, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70752 +/- ##
===========================================
+ Coverage 56.77% 80.00% +23.23%
===========================================
Files 6495 6506 +11
Lines 290288 290793 +505
Branches 50055 50123 +68
===========================================
+ Hits 164798 232661 +67863
+ Misses 125049 57696 -67353
+ Partials 441 436 -5
|
2 participants
the first large chunk of
CanoncalKeyDicterrors are related to sample data still having the legacy keys -- this fixes those