Skip to content

Conversation

@shellmayr
Copy link
Member

@shellmayr shellmayr commented May 15, 2024

  • Add an empty Sequence option to defaults to remove percentiles from being return from metrics/meta as queryable operations in the Metrics API.
  • If in the future, we want to turn on percentiles on a per-org-basis, this option can then be used to do that.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 15, 2024
@codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (73d4ff9) to head (e0eb8ac).
Report is 56 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70934      +/-   ##
==========================================
- Coverage   80.02%   77.92%   -2.10%     
==========================================
  Files        6509     6506       -3     
  Lines      291345   290198    -1147     
  Branches    50218    50225       +7     
==========================================
- Hits       233142   226135    -7007     
+ Misses      57769    57765       -4     
- Partials      434     6298    +5864     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
...sentry/sentry_metrics/querying/metadata/metrics.py 82.69% <100.00%> (-3.36%) ⬇️
...c/sentry/sentry_metrics/querying/metadata/utils.py 100.00% <100.00%> (ø)
src/sentry/snuba/metrics/datasource.py 95.59% <100.00%> (+3.56%) ⬆️

... and 1572 files with indirect coverage changes

@shellmayr shellmayr marked this pull request as ready for review May 16, 2024 07:39
@shellmayr shellmayr requested a review from a team as a code owner May 16, 2024 07:39
@shellmayr shellmayr merged commit cebc8c7 into master May 17, 2024
@shellmayr shellmayr deleted the shellmayr/feat/remove-percentiles-from-metrics-api-v2 branch May 17, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants