fix(dashboards): Release filter should apply conditions over base query #71101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using OR filters, the previous application of filters would result in incorrect results. A OR B AND C is not the same as (A OR B) AND C, which is the proper way to apply the filter to the base query of a widget.
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 703.96kB ⬆️
|
Zylphrex
approved these changes
May 17, 2024
narsaynorath
deleted the
nar/fix/dashboard-release-filters-applied-with-or
branch
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
…ry (#71101) When using OR filters, the previous application of filters would result in incorrect results. A OR B AND C is not the same as (A OR B) AND C, which is the proper way to apply the filter to the base query of a widget.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using OR filters, the previous application of filters would result in incorrect results. A OR B AND C is not the same as (A OR B) AND C, which is the proper way to apply the filter to the base query of a widget.