Skip to content

feat(profiling): enable profiling measurement charts if measurements are sent #71258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasBa merged 1 commit into from
May 28, 2024
Merged

feat(profiling): enable profiling measurement charts if measurements are sent #71258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions static/app/components/profiling/flamegraph/flamegraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,18 +240,28 @@ function Flamegraph(): ReactElement {

const hasBatteryChart = useMemo(() => {
const platform = profileGroup.metadata.platform;
return platform === 'cocoa';
}, [profileGroup.metadata.platform]);
return platform === 'cocoa' || profileGroup.measurements?.cpu_energy_usage;
}, [profileGroup.metadata.platform, profileGroup.measurements]);

const hasCPUChart = useMemo(() => {
const platform = profileGroup.metadata.platform;
return platform === 'cocoa' || platform === 'android' || platform === 'node';
}, [profileGroup.metadata.platform]);
return (
platform === 'cocoa' ||
platform === 'android' ||
platform === 'node' ||
profileGroup.measurements?.cpu_usage
);
}, [profileGroup.metadata.platform, profileGroup.measurements]);

const hasMemoryChart = useMemo(() => {
const platform = profileGroup.metadata.platform;
return platform === 'cocoa' || platform === 'android' || platform === 'node';
}, [profileGroup.metadata.platform]);
return (
platform === 'cocoa' ||
platform === 'android' ||
platform === 'node' ||
profileGroup.measurements?.memory_footprint
);
}, [profileGroup.metadata.platform, profileGroup.measurements]);

const profile = useMemo(() => {
return profileGroup.profiles.find(p => p.threadId === threadId);
Expand Down