Skip to content

feat(chartcuterie): Revert the revert of refactory#71885

Merged
sentaur-athena merged 3 commits into
masterfrom
athena/redo-refactory
Jun 3, 2024
Merged

feat(chartcuterie): Revert the revert of refactory#71885
sentaur-athena merged 3 commits into
masterfrom
athena/redo-refactory

Conversation

@sentaur-athena

Copy link
Copy Markdown
Member

#71786 broke in canary so I reverted it. This PR reverts the revert, fixes the issue and adds test for it.

@sentaur-athena sentaur-athena requested a review from a team as a code owner May 31, 2024 22:19
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 31, 2024
@sentaur-athena sentaur-athena changed the title Athena/redo refactory feat(chartcuterie): Revert the revert of refactory May 31, 2024
@sentaur-athena sentaur-athena requested a review from a team May 31, 2024 22:20

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the issue that broke the canary. I didn't define the image_url before.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And therefore if it wasn't part of the supported issues it would throw an error so adding unsupported issue here to the test. https://sentry.sentry.io/issues/5434963970/

@sentaur-athena sentaur-athena force-pushed the athena/redo-refactory branch from 9a83442 to 4a8016c Compare May 31, 2024 22:26
@codecov

codecov Bot commented May 31, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.70968% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 77.90%. Comparing base (d92153e) to head (1c5aba2).
Report is 87 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #71885   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files        6555     6557    +2     
  Lines      292198   292268   +70     
  Branches    50475    50485   +10     
=======================================
+ Hits       227633   227698   +65     
- Misses      58312    58315    +3     
- Partials     6253     6255    +2     
Files Coverage Δ
...tions/slack/message_builder/image_block_builder.py 100.00% <100.00%> (+21.05%) ⬆️
...c/sentry/integrations/issue_alert_image_builder.py 86.79% <86.79%> (ø)

... and 48 files with indirect coverage changes

@sentaur-athena sentaur-athena force-pushed the athena/redo-refactory branch from 4a8016c to 1c5aba2 Compare May 31, 2024 22:34
@sentaur-athena sentaur-athena merged commit 2300745 into master Jun 3, 2024
@sentaur-athena sentaur-athena deleted the athena/redo-refactory branch June 3, 2024 15:05
@sentry

sentry Bot commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApiError: status=400 body={'detail': ErrorDetail(string='message is not a tag in the metrics dataset', code... sentry.tasks.activity.send_activity_notifications View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants