feat(chartcuterie): Revert the revert of refactory#71885
Merged
Conversation
sentaur-athena
commented
May 31, 2024
Member
Author
There was a problem hiding this comment.
This was the issue that broke the canary. I didn't define the image_url before.
Member
Author
There was a problem hiding this comment.
And therefore if it wasn't part of the supported issues it would throw an error so adding unsupported issue here to the test. https://sentry.sentry.io/issues/5434963970/
ykamo001
approved these changes
May 31, 2024
9a83442 to
4a8016c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71885 +/- ##
=======================================
Coverage 77.90% 77.90%
=======================================
Files 6555 6557 +2
Lines 292198 292268 +70
Branches 50475 50485 +10
=======================================
+ Hits 227633 227698 +65
- Misses 58312 58315 +3
- Partials 6253 6255 +2
|
4a8016c to
1c5aba2
Compare
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#71786 broke in canary so I reverted it. This PR reverts the revert, fixes the issue and adds test for it.