Skip to content

Conversation

@ArthurKnaus
Copy link
Member

Move EquationSymbol and QuerySymbol to components/metrics folder.
Add tests.

@ArthurKnaus ArthurKnaus requested a review from a team as a code owner June 6, 2024 06:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2024
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (e696b21) to head (f08bd77).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72192   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files        6576     6576           
  Lines      293026   293007   -19     
  Branches    50578    50574    -4     
=======================================
- Hits       228506   228500    -6     
+ Misses      58294    58269   -25     
- Partials     6226     6238   +12     
Files Coverage Δ
static/app/components/metrics/equationSymbol.tsx 100.00% <ø> (ø)
static/app/components/metrics/querySymbol.tsx 95.00% <ø> (ø)
...ponents/modals/metricWidgetViewerModal/queries.tsx 0.00% <ø> (ø)
static/app/utils/metrics/dashboardImport.tsx 76.96% <ø> (ø)
static/app/views/dashboards/metrics/utils.tsx 77.52% <ø> (ø)
static/app/views/metrics/pageHeaderActions.tsx 0.00% <ø> (ø)
static/app/views/metrics/queries.tsx 0.00% <ø> (ø)
...app/views/metrics/utils/useFormulaDependencies.tsx 0.00% <ø> (ø)
static/app/views/metrics/utils/widgetToQuery.tsx 0.00% <ø> (ø)

... and 83 files with indirect coverage changes

…move-equation-and-query-symbol-to-components
@ArthurKnaus ArthurKnaus enabled auto-merge (squash) June 6, 2024 10:01
@ArthurKnaus ArthurKnaus merged commit c518673 into master Jun 6, 2024
@ArthurKnaus ArthurKnaus deleted the aknaus/ref/metrics/move-equation-and-query-symbol-to-components branch June 6, 2024 10:13
ArthurKnaus added a commit that referenced this pull request Jun 6, 2024
Move `EquationSymbol` and `QuerySymbol` to `components/metrics` folder.
Add tests.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants