Skip to content

feat(spans): Support autocompleting project slugs#72629

Merged
Zylphrex merged 1 commit intomasterfrom
txiao/feat/support-autocompleting-project-slugs
Jun 12, 2024
Merged

feat(spans): Support autocompleting project slugs#72629
Zylphrex merged 1 commit intomasterfrom
txiao/feat/support-autocompleting-project-slugs

Conversation

@Zylphrex
Copy link
Copy Markdown
Member

Project slugs are not in clickhouse so override the behaviour and implement autocompletion logic in sentry directly.

Project slugs are not in clickhouse so override the behaviour and implement
autocompletion logic in sentry directly.
@Zylphrex Zylphrex requested a review from a team June 12, 2024 17:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2024
Copy link
Copy Markdown
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (ec99071) to head (00e3597).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72629       +/-   ##
===========================================
+ Coverage   56.95%   78.05%   +21.09%     
===========================================
  Files        6585     6596       +11     
  Lines      293561   293950      +389     
  Branches    50649    50704       +55     
===========================================
+ Hits       167210   229435    +62225     
+ Misses     121629    58254    -63375     
- Partials     4722     6261     +1539     
Files Coverage Δ
.../sentry/api/endpoints/organization_spans_fields.py 100.00% <100.00%> (+48.43%) ⬆️
src/sentry/options/defaults.py 100.00% <ø> (ø)

... and 1982 files with indirect coverage changes

@Zylphrex Zylphrex merged commit dc0ab0a into master Jun 12, 2024
@Zylphrex Zylphrex deleted the txiao/feat/support-autocompleting-project-slugs branch June 12, 2024 18:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants