feat(spans): Support recent searches#72938
Merged
Merged
Conversation
We were using the event search type for trace search. Creating a span type so we can switch over.
github-actions
Bot
added
the
Scope: Backend
Zylphrex
added a commit
that referenced
this pull request
Jun 18, 2024
This was using the event type so searches from other parts of the product like discover were being mixed here. Switch to use it's own type. Depends on #72938
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72938 +/- ##
==========================================
+ Coverage 73.27% 78.05% +4.77%
==========================================
Files 6602 6606 +4
Lines 294280 294505 +225
Branches 50731 50764 +33
==========================================
+ Hits 215645 229881 +14236
+ Misses 72049 58294 -13755
+ Partials 6586 6330 -256
|
k-fish
approved these changes
Jun 18, 2024
Zylphrex
added a commit
that referenced
this pull request
Jun 18, 2024
This was using the event type so searches from other parts of the product like discover were being mixed here. Switch to use it's own type. Depends on #72938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using the event search type for trace search. Creating a span type so we can switch over.