ref(onboarding): add hook for gettingStartedDocs#73439
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73439 +/- ##
===========================================
+ Coverage 56.71% 77.94% +21.22%
===========================================
Files 6628 6631 +3
Lines 296520 295033 -1487
Branches 51067 50752 -315
===========================================
+ Hits 168169 229959 +61790
+ Misses 123680 58738 -64942
- Partials 4671 6336 +1665
|
michellewzhang
approved these changes
Jun 27, 2024
michellewzhang
left a comment
Contributor
There was a problem hiding this comment.
this is super nit and also my fault, but i don't like how i named the feedback one useLoadFeedbackOnboardingDoc and the replays one just useLoadOnboardingDoc ... do you mind renaming these to be either the same or the replay one to be useLoadReplayOnboardingDoc?
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this replaces a useEffect that was used in a few different places with a custom hook.