Skip to content

ref(onboarding): add hook for gettingStartedDocs#73439

Merged
roggenkemper merged 6 commits into
masterfrom
roggenkemper/docshook
Jun 28, 2024
Merged

ref(onboarding): add hook for gettingStartedDocs#73439
roggenkemper merged 6 commits into
masterfrom
roggenkemper/docshook

Conversation

@roggenkemper

Copy link
Copy Markdown
Member

this replaces a useEffect that was used in a few different places with a custom hook.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 27, 2024
@codecov

codecov Bot commented Jun 27, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.94%. Comparing base (7d1d769) to head (eec13ce).

Current head eec13ce differs from pull request most recent head 7ceecf9

Please upload reports for the commit 7ceecf9 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73439       +/-   ##
===========================================
+ Coverage   56.71%   77.94%   +21.22%     
===========================================
  Files        6628     6631        +3     
  Lines      296520   295033     -1487     
  Branches    51067    50752      -315     
===========================================
+ Hits       168169   229959    +61790     
+ Misses     123680    58738    -64942     
- Partials     4671     6336     +1665     
Files Coverage Δ
...eedbackOnboarding/useLoadFeedbackOnboardingDoc.tsx 0.00% <0.00%> (ø)
.../onboarding/gettingStartedDoc/sdkDocumentation.tsx 80.00% <50.00%> (-8.24%) ⬇️
...s/replaysOnboarding/useLoadReplayOnboardingDoc.tsx 0.00% <0.00%> (ø)
.../gettingStartedDoc/utils/useLoadGettingStarted.tsx 73.33% <73.33%> (ø)

... and 2242 files with indirect coverage changes

@roggenkemper roggenkemper changed the title chore(onboarding): add hook for gettingStartedDocs ref(onboarding): add hook for gettingStartedDocs Jun 27, 2024
@roggenkemper roggenkemper marked this pull request as ready for review June 27, 2024 19:58
@roggenkemper roggenkemper requested a review from a team as a code owner June 27, 2024 19:58

@michellewzhang michellewzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super nit and also my fault, but i don't like how i named the feedback one useLoadFeedbackOnboardingDoc and the replays one just useLoadOnboardingDoc ... do you mind renaming these to be either the same or the replay one to be useLoadReplayOnboardingDoc?

@roggenkemper roggenkemper merged commit 79b8d4f into master Jun 28, 2024
@roggenkemper roggenkemper deleted the roggenkemper/docshook branch June 28, 2024 17:05
@sentry

sentry Bot commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Cannot find module './python/python-celery' /feedback/ View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants