perf(spans): Use bf index on tag keys#73471
Merged
Merged
Conversation
The spans table has a bloom filter index on the tag keys. Make sure to add the right condition to make sure the index is applied.
vartec
approved these changes
Jun 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73471 +/- ##
=======================================
Coverage 78.01% 78.01%
=======================================
Files 6634 6634
Lines 296733 296754 +21
Branches 51108 51110 +2
=======================================
+ Hits 231490 231515 +25
Misses 58855 58855
+ Partials 6388 6384 -4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spans table has a bloom filter index on the tag keys. Make sure to add the right condition to make sure the index is applied.