Skip to content

perf(spans): Use bf index on tag keys#73471

Merged
Zylphrex merged 1 commit into
masterfrom
txiao/perf/use-bf-index-on-tag-keys
Jun 28, 2024
Merged

perf(spans): Use bf index on tag keys#73471
Zylphrex merged 1 commit into
masterfrom
txiao/perf/use-bf-index-on-tag-keys

Conversation

@Zylphrex

Copy link
Copy Markdown
Member

The spans table has a bloom filter index on the tag keys. Make sure to add the right condition to make sure the index is applied.

The spans table has a bloom filter index on the tag keys. Make sure to add the
right condition to make sure the index is applied.
@Zylphrex Zylphrex requested a review from a team as a code owner June 27, 2024 21:35
@Zylphrex Zylphrex requested a review from a team June 27, 2024 21:35
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 27, 2024
@codecov

codecov Bot commented Jun 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (88ac464) to head (bd63794).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73471   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files        6634     6634           
  Lines      296733   296754   +21     
  Branches    51108    51110    +2     
=======================================
+ Hits       231490   231515   +25     
  Misses      58855    58855           
+ Partials     6388     6384    -4     
Files Coverage Δ
src/sentry/search/events/builder/base.py 91.84% <100.00%> (+0.04%) ⬆️
src/sentry/search/events/datasets/base.py 87.80% <100.00%> (+0.30%) ⬆️
src/sentry/search/events/datasets/spans_indexed.py 88.57% <100.00%> (+0.16%) ⬆️

... and 10 files with indirect coverage changes

@Zylphrex Zylphrex merged commit c830eda into master Jun 28, 2024
@Zylphrex Zylphrex deleted the txiao/perf/use-bf-index-on-tag-keys branch June 28, 2024 12:50
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants