Skip to content

chore(insights): removes no longer needed webvitals weighted score calculation workaround#73506

Merged
edwardgou-sentry merged 2 commits into
masterfrom
egou/chore/remove-weighted-score-workaround
Jul 2, 2024
Merged

chore(insights): removes no longer needed webvitals weighted score calculation workaround#73506
edwardgou-sentry merged 2 commits into
masterfrom
egou/chore/remove-weighted-score-workaround

Conversation

@edwardgou-sentry

@edwardgou-sentry edwardgou-sentry commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

It has been over 90 days since we fixed an issue with double counting transactions (getsentry/relay#3324), so we no longer need this score calculation workaround.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 28, 2024
@codecov

codecov Bot commented Jun 28, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (48e48f4) to head (8c16f67).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73506   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files        6634     6636    +2     
  Lines      296774   296770    -4     
  Branches    51111    51110    -1     
=======================================
+ Hits       231533   231536    +3     
+ Misses      58854    58850    -4     
+ Partials     6387     6384    -3     
Files Coverage Δ
src/sentry/features/temporary.py 100.00% <ø> (ø)
src/sentry/search/events/datasets/metrics.py 82.37% <ø> (+0.32%) ⬆️

... and 42 files with indirect coverage changes

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review June 28, 2024 16:04
@edwardgou-sentry edwardgou-sentry requested a review from a team June 28, 2024 16:04
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner June 28, 2024 16:04
@edwardgou-sentry edwardgou-sentry merged commit d754125 into master Jul 2, 2024
@edwardgou-sentry edwardgou-sentry deleted the egou/chore/remove-weighted-score-workaround branch July 2, 2024 14:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants