Skip to content

Conversation

@cathteng
Copy link
Member

These are already very occasionally being emitted as Sentry errors, but it would be good to look at them relative to all Slack responses being recorded in DD. This error is emitted from Slack, and is not due to us.

@cathteng cathteng requested a review from a team June 28, 2024 22:04
@cathteng cathteng requested a review from a team as a code owner June 28, 2024 22:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 28, 2024
@codecov
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (280454e) to head (06ba4ad).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73546      +/-   ##
==========================================
+ Coverage   77.01%   78.02%   +1.00%     
==========================================
  Files        6638     6638              
  Lines      296878   296880       +2     
  Branches    51122    51123       +1     
==========================================
+ Hits       228655   231639    +2984     
+ Misses      61817    58967    -2850     
+ Partials     6406     6274     -132     
Files Coverage Δ
src/sentry/integrations/slack/sdk_client.py 77.63% <100.00%> (+0.60%) ⬆️

... and 272 files with indirect coverage changes

@cathteng cathteng merged commit 880e6d4 into master Jul 1, 2024
@cathteng cathteng deleted the cathy/slack/sdk-track-timeouts branch July 1, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants