chore(slack): Use Slack SDK Client in validate_channel_id#73659
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73659 +/- ##
=======================================
Coverage 78.03% 78.04%
=======================================
Files 6640 6642 +2
Lines 297033 297083 +50
Branches 51152 51125 -27
=======================================
+ Hits 231797 231848 +51
Misses 58961 58961
+ Partials 6275 6274 -1
|
RyanSkonnord
reviewed
Jul 2, 2024
| "integration_id": integration_id, | ||
| "channel_name": name, | ||
| "input_channel_id": input_channel_id, | ||
| } |
Contributor
There was a problem hiding this comment.
Nit: Are we trying to follow a convention of declaring logger_params as a local variable? I don't think it's necessary unless the same params are logged in multiple places.
| if e.text == "channel_not_found": | ||
| raise ValidationError("Channel not found. Invalid ID provided.") | ||
| _logger.info("rule.slack.conversation_info_failed", extra={"error": str(e)}) | ||
| raise IntegrationError("Could not retrieve Slack channel information.") |
Contributor
There was a problem hiding this comment.
All four of these raise statements should have from e at the end.
RyanSkonnord
approved these changes
Jul 2, 2024
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
validate_channel_idto use to Slack SDK. Wrote Tests and Tested Locally. AddressesSDK-2.22