Skip to content

chore(features) Remove feature for issue-details-tag-improvements#73841

Merged
markstory merged 1 commit into
masterfrom
chore-remove-issue-details-tag
Jul 4, 2024
Merged

chore(features) Remove feature for issue-details-tag-improvements#73841
markstory merged 1 commit into
masterfrom
chore-remove-issue-details-tag

Conversation

@markstory

Copy link
Copy Markdown
Member

This feature has a partial rollout, and is causing noise when comparing flagr and flagpole results. Turns out this feature has already been mainlined/removed.

This feature has a partial rollout, and is causing noise when comparing
flagr and flagpole results. Turns out this feature has already been
mainlined/removed.
@markstory markstory requested review from a team and edwardgou-sentry July 4, 2024 14:32
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jul 4, 2024
@github-actions

github-actions Bot commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@codecov

codecov Bot commented Jul 4, 2024

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 403 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.3MB 403 bytes ⬆️

@codecov

codecov Bot commented Jul 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (a3bcefe) to head (7658c9d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73841       +/-   ##
===========================================
+ Coverage   54.20%   78.11%   +23.91%     
===========================================
  Files        5604     6659     +1055     
  Lines      236527   297935    +61408     
  Branches    40506    51257    +10751     
===========================================
+ Hits       128200   232733   +104533     
+ Misses     106917    58915    -48002     
- Partials     1410     6287     +4877     
Files Coverage Δ
src/sentry/conf/server.py 87.82% <ø> (+0.16%) ⬆️
src/sentry/features/temporary.py 100.00% <ø> (ø)

... and 2319 files with indirect coverage changes

@markstory markstory merged commit f08644a into master Jul 4, 2024
@markstory markstory deleted the chore-remove-issue-details-tag branch July 4, 2024 16:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants