Move sampling decision into traces_sampler for occurence consumer.#74426
Closed
antonpirker wants to merge 8 commits into
Closed
Move sampling decision into traces_sampler for occurence consumer.#74426antonpirker wants to merge 8 commits into
traces_sampler for occurence consumer.#74426antonpirker wants to merge 8 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
jan-auer
reviewed
Jul 17, 2024
| op="_process_message", | ||
| name="issues.occurrence_consumer", | ||
| sampled=True, | ||
| custom_sampling_context={"sample_rate": 1.0}, |
Member
There was a problem hiding this comment.
Same as in #74425
For now you can also leave sampled=True here. I'd change this only once we get rid of sampled.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74426 +/- ##
==========================================
+ Coverage 78.02% 78.11% +0.08%
==========================================
Files 6677 6677
Lines 298750 298750
Branches 51433 51433
==========================================
+ Hits 233107 233369 +262
+ Misses 59372 59115 -257
+ Partials 6271 6266 -5
|
Contributor
Author
|
OK, then I will close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #74340