ref(querybuilder): Remove ParamsType from tasks #74570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This removes the usage of ParamsType from tasks in favour of SnubaParams - Added stats_period as an option to SnubaParams as a way to define start and end
github-actions
bot
added
the
Scope: Backend
wmak
commented
Jul 19, 2024
Comment on lines
+930
to
+934
| params = SnubaParams( | ||
| start=end - timedelta(days=14), | ||
| end=end, | ||
| projects=projects, | ||
| ) |
Member
Author
There was a problem hiding this comment.
Didn't use SnubaParams(stats_period= here since the existing functionality sets end to 1hr in the future
Zylphrex
reviewed
Jul 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74570 +/- ##
==========================================
+ Coverage 68.75% 78.17% +9.42%
==========================================
Files 6687 6692 +5
Lines 299181 299562 +381
Branches 51536 51575 +39
==========================================
+ Hits 205689 234186 +28497
+ Misses 86738 59052 -27686
+ Partials 6754 6324 -430
|
- Added automatic self.organization grabbing which the ParamsType -> SnubaParams converter was doing automatically
Zylphrex
approved these changes
Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_top_events_timeseries_resultseven thoughparams={}now)