Skip to content

Conversation

@markstory
Copy link
Member

  • Add api_expose=False to features that aren't used in sentry or getsentry frontend.
  • Add api_expose=True to features that are used in getsentry UI, and some that I missed last time.

This should improve the response time of organization details as we will be checking fewer feature flags on each request.

Refs HC-1197

- Add api_expose=False to features that aren't used in sentry or
  getsentry frontend.
- Add api_expose=True to features that are used in getsentry UI, and
  some that I missed last time.

This should improve the response time of organization details as we will
be checking fewer feature flags on each request.

Refs HC-1197
@markstory markstory requested review from a team July 19, 2024 16:54
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 19, 2024
@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (032ddf2) to head (016deb6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74572      +/-   ##
==========================================
- Coverage   78.15%   78.15%   -0.01%     
==========================================
  Files        6724     6724              
  Lines      299904   299904              
  Branches    51591    51591              
==========================================
- Hits       234386   234380       -6     
- Misses      59195    59202       +7     
+ Partials     6323     6322       -1     
Files Coverage Δ
src/sentry/apidocs/examples/project_examples.py 100.00% <ø> (ø)
src/sentry/features/temporary.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@markstory markstory merged commit 9d2bbbe into master Jul 22, 2024
@markstory markstory deleted the chore-feature-expose-false branch July 22, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants