Skip to content

Conversation

@jangjodi
Copy link
Contributor

Add enable ingestion flag to backfill endpoint
Add enable ingestion flag in backfill
If the flag is enabled, add sentry:similarity_backfill_completed to project options (to be checked in ingestion)

@jangjodi jangjodi requested a review from a team as a code owner July 19, 2024 19:06
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 19, 2024
@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (dd35653) to head (357d094).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #74586   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files        6693     6693           
  Lines      299544   299558   +14     
  Branches    51564    51566    +2     
=======================================
+ Hits       234170   234183   +13     
- Misses      59057    59058    +1     
  Partials     6317     6317           
Files Coverage Δ
...ject_backfill_similar_issues_embeddings_records.py 93.33% <100.00%> (+0.74%) ⬆️
...ping/backfill_seer_grouping_records_for_project.py 91.46% <ø> (ø)
src/sentry/tasks/embeddings_grouping/utils.py 91.85% <100.00%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

@jangjodi jangjodi merged commit 34d9dc6 into master Jul 22, 2024
@jangjodi jangjodi deleted the jodi/backfill-enable-ingestion branch July 22, 2024 19:35
@sentry
Copy link

sentry bot commented Jul 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: assert {'request_has...ersion': 'v0'} == {'request_has...ersion': 'v0'} pytest.runtest.protocol tests/sentry/tasks/test... View Issue
  • ‼️ AssertionError: assert {'request_has...ersion': 'v0'} == {'request_has...ersion': 'v0'} pytest.runtest.protocol tests/sentry/tasks/test... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants