Skip to content

feat(replays): Emit mobile replay outcomes #74649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2024
Merged

feat(replays): Emit mobile replay outcomes #74649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72bfac1
Emit mobile replay outcome for segment 0 events
cmanallen Jul 22, 2024
167f5dc
Rename to replay video
cmanallen Jul 22, 2024
4866e76
Merge branch 'master' into cmanallen/replays-emit-mobile-outcome
cmanallen Jul 24, 2024
970c88a
Merge branch 'master' into cmanallen/replays-emit-mobile-outcome
cmanallen Jul 25, 2024
8c66500
Update relay requirement
cmanallen Jul 25, 2024
808d387
Upgrade dependencies
cmanallen Jul 25, 2024
bf45c1e
Update coverage
cmanallen Jul 25, 2024
c2a7b9a
Merge branch 'master' into cmanallen/replays-emit-mobile-outcome
cmanallen Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements-base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ sentry-arroyo>=2.16.5
sentry-kafka-schemas>=0.1.101
sentry-ophio==0.2.7
sentry-redis-tools>=0.1.7
sentry-relay>=0.9.0
sentry-relay>=0.9.1
sentry-sdk>=2.11.0
slack-sdk>=3.27.2
snuba-sdk>=2.0.33
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev-frozen.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ sentry-forked-djangorestframework-stubs==3.15.0.post1
sentry-kafka-schemas==0.1.101
sentry-ophio==0.2.7
sentry-redis-tools==0.1.7
sentry-relay==0.9.0
sentry-relay==0.9.1
sentry-sdk==2.11.0
sentry-usage-accountant==0.0.10
simplejson==3.17.6
Expand Down
2 changes: 1 addition & 1 deletion requirements-frozen.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ sentry-arroyo==2.16.5
sentry-kafka-schemas==0.1.101
sentry-ophio==0.2.7
sentry-redis-tools==0.1.7
sentry-relay==0.9.0
sentry-relay==0.9.1
sentry-sdk==2.11.0
sentry-usage-accountant==0.0.10
simplejson==3.17.6
Expand Down
14 changes: 13 additions & 1 deletion src/sentry/replays/usecases/ingest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,19 @@ def track_initial_segment_event(
first_replay_received.send_robust(project=project, sender=Project)

# Replay videos are not billed for now.
Copy link
Contributor

@asottile-sentry asottile-sentry Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is outdated?

Copy link
Member Author

@cmanallen cmanallen Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this outcome is not billed. We're adding it so the PMs can access the data in looker.

Copy link
Contributor

@asottile-sentry asottile-sentry Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally: should there be a test covering this change?

if not is_replay_video:
if is_replay_video:
track_outcome(
org_id=org_id,
project_id=project_id,
key_id=key_id,
outcome=Outcome.ACCEPTED,
reason=None,
timestamp=datetime.fromtimestamp(received, timezone.utc),
event_id=replay_id,
category=DataCategory.REPLAY_VIDEO,
quantity=1,
)
else:
track_outcome(
org_id=org_id,
project_id=project_id,
Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/replays/consumers/test_recording.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def test_event_with_replay_video(self, track_outcome, mock_record, mock_onboardi
user_id=self.organization.default_owner_id,
)

assert not track_outcome.called
assert track_outcome.called

@patch("sentry.models.OrganizationOnboardingTask.objects.record")
@patch("sentry.analytics.record")
Expand Down