Skip to content

Conversation

@malwilley
Copy link
Member

@malwilley malwilley commented Jul 22, 2024

Closes #74350

Adds disallowWildcard config option. Will mark invalid tokens and free text as red and display a tooltip explaining the issue.

Can play around with the config option in the new section I've added to the story: /stories/?name=app/components/searchQueryBuilder/index.stories.tsx

CleanShot 2024-07-22 at 14 25 14

@malwilley malwilley requested a review from a team July 22, 2024 21:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 22, 2024
@codecov
Copy link

codecov bot commented Jul 22, 2024

Bundle Report

Changes will increase total bundle size by 56.65kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.2MB 56.65kB ⬆️

Copy link
Member

@roggenkemper roggenkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't wait to see the 15 other PRs that depend on this to get merged

@malwilley malwilley merged commit 078c9f0 into master Jul 23, 2024
@malwilley malwilley deleted the malwilley/feat/search-query-disallow-wildcard branch July 23, 2024 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchQuertyBuilder: Support disallow wildcards config

3 participants