fix(toolbar): hide feedback panel when submit feedback form opens #74679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 25.36kB ⬆️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74679 +/- ##
==========================================
- Coverage 78.15% 78.14% -0.02%
==========================================
Files 6723 6733 +10
Lines 299958 300140 +182
Branches 51614 51621 +7
==========================================
+ Hits 234437 234549 +112
- Misses 59195 59265 +70
Partials 6326 6326
|
Member
|
the submit feedback modal doesn't seem to show up when i try clicking + (edit: ahh i see your slack message) Screen.Recording.2024-07-22.at.3.22.59.PM.mov |
…as well as the panel(s)
aliu39
force-pushed
the
aliu/hide-toolbar-modal
branch
from
76e7d46 to
7822bf7
Compare
ryan953
reviewed
Jul 23, 2024
| import type {CSSProperties, Dispatch, ReactNode, SetStateAction} from 'react'; | ||
| import {createContext, useContext, useState} from 'react'; | ||
|
|
||
| type State = CSSProperties['visibility']; |
ryan953
approved these changes
Jul 23, 2024
billyvg
approved these changes
Jul 23, 2024
Member
Author
|
Too late to change the title now but after the above recordings, this was changed to hide the entire toolbar (incl navigation bar) when the feedback widget is open |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74156 so the toolbar will be totally hidden when submitting feedback / taking a screenshot.
Screen.Recording.2024-07-23.at.12.03.53.PM.mov