fix(hybrid-cloud): Fix private field for RpcOrganization model #74748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74748 +/- ##
==========================================
- Coverage 78.14% 78.14% -0.01%
==========================================
Files 6730 6731 +1
Lines 300110 300214 +104
Branches 51623 51642 +19
==========================================
+ Hits 234528 234600 +72
- Misses 59257 59286 +29
- Partials 6325 6328 +3
|
GabeVillalobos
approved these changes
Jul 23, 2024
Christinarlong
pushed a commit
that referenced
this pull request
Jul 26, 2024
Fields in RPC models that begin with underscores are automatically excluded: https://docs.pydantic.dev/1.10/usage/models/#automatically-excluded-attributes To avoid this, we need to mark them with [`PrivateAttr()`](https://docs.pydantic.dev/1.10/usage/models/#private-model-attributes). Otherwise, `RpcOrganization.default_owner_id` will always return `None`. This is needed for getsentry/getsentry#14709.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields in RPC models that begin with underscores are automatically excluded: https://docs.pydantic.dev/1.10/usage/models/#automatically-excluded-attributes
To avoid this, we need to mark them with
PrivateAttr().Otherwise,
RpcOrganization.default_owner_idwill always returnNone.This is needed for https://github.com/getsentry/getsentry/pull/14709.