Skip to content

fix(hybrid-cloud): Fix private field for RpcOrganization model #74748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(hybrid-cloud): Fix private field for RpcOrganization model #74748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/sentry/organizations/services/organization/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from django.dispatch import Signal
from django.utils import timezone
from pydantic import Field
from pydantic import Field, PrivateAttr
from typing_extensions import TypedDict

from sentry import roles
Expand Down Expand Up @@ -249,7 +249,7 @@ class RpcOrganization(RpcOrganizationSummary):

default_role: str = ""
date_added: datetime = Field(default_factory=timezone.now)
_default_owner_id: int | None = None
_default_owner_id: int | None = PrivateAttr(default=None)

def get_audit_log_data(self) -> dict[str, Any]:
return {
Expand Down Expand Up @@ -286,7 +286,7 @@ def default_owner_id(self) -> int | None:

This mirrors the method on the Organization model.
"""
if not hasattr(self, "_default_owner_id"):
if getattr(self, "_default_owner_id") is None:
owners = self.get_owners()
if len(owners) == 0:
return None
Expand Down