Make sure end_timestamp_precise and organization_id are sent to snuba#74788
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74788 +/- ##
========================================
Coverage 78.14% 78.15%
========================================
Files 6730 6731 +1
Lines 300110 300282 +172
Branches 51623 51652 +29
========================================
+ Hits 234528 234690 +162
- Misses 59257 59266 +9
- Partials 6325 6326 +1
|
Contributor
|
Adding the fields here is what really allows us to remove the https://github.com/getsentry/sentry-kafka-schemas/blob/main/schemas/snuba-spans.v1.schema.json#L101 |
phacops
requested changes
Jul 24, 2024
phacops
left a comment
phacops
left a comment
Contributor
There was a problem hiding this comment.
It'd be wise to test this against your consumer branch before we merge.
colin-sentry
force-pushed
the
test_improvements
branch
from
9d30703 to
18ad9a1
Compare
phacops
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… from tests
This lets us remove some Optionals from snuba