feat(profiling): Pass thread id to flamegraph generation#74846
Merged
Zylphrex merged 2 commits intoJul 25, 2024
Conversation
To generate a more accurate flamegraph, we want samples from the active thread.
github-actions
Bot
added
the
Scope: Backend
viglia
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74846 +/- ##
===========================================
+ Coverage 54.34% 78.13% +23.78%
===========================================
Files 5679 6740 +1061
Lines 239161 300847 +61686
Branches 40977 51745 +10768
===========================================
+ Hits 129982 235052 +105070
+ Misses 107732 59456 -48276
- Partials 1447 6339 +4892
|
Christinarlong
pushed a commit
that referenced
this pull request
Jul 26, 2024
To generate a more accurate flamegraph, we want samples from the active thread. Depends on getsentry/snuba#6138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To generate a more accurate flamegraph, we want samples from the active thread.
Depends on getsentry/snuba#6138