feat(tabs): Add new variant to be used on issue details #75029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75029 +/- ##
==========================================
- Coverage 78.12% 78.12% -0.01%
==========================================
Files 6745 6746 +1
Lines 301168 301177 +9
Branches 51823 51825 +2
==========================================
+ Hits 235289 235290 +1
- Misses 59555 59563 +8
Partials 6324 6324
|
malwilley
reviewed
Jul 29, 2024
malwilley
approved these changes
Jul 29, 2024
ryan953
reviewed
Jul 29, 2024
| <p>You can also use the "floating" variant, which is used below</p> | ||
| <SizingWindow> | ||
| <Tabs> | ||
| <TabList variant="floating" hideBorder> |
There was a problem hiding this comment.
This could use a Matrix to better show the different values along side each other, i'd use Matrix to compate with hideBorder and also with orientation
roggenkemper
added a commit
that referenced
this pull request
Jul 29, 2024
this pr uses the new tab design introduced in #75029 for the streamlined event navigation component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a new variant of tabs - "floating" , which will be used on the updated issue details page