ref(querybuilder): Change profiling profiles to use snuba params #75070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Jul 26, 2024
wmak
commented
- This updates the profiling profiles endpoint to use snuba params over the paramstype
- Needed to add quantize_date_params as a param to be compatible
- This updates the profiling profiles endpoint to use snuba params over the paramstype - Needed to add quantize_date_params as a param to be compatible
github-actions
bot
added
the
Scope: Backend
wmak
commented
Jul 26, 2024
| assert response.status_code == 400, response.data | ||
| assert response.data == { | ||
| "detail": ErrorDetail( | ||
| "You cannot view events from multiple projects.", |
Member
Author
There was a problem hiding this comment.
Based on the name of this test, i think this is the correct error message?
wmak
commented
Jul 26, 2024
Comment on lines
+109
to
+114
| @property | ||
| def start_date(self) -> datetime: | ||
| # This and end_date are helper functions so callers don't have to check if either are defined for typing | ||
| if self.start is None: | ||
| raise InvalidSearchQuery("start is required") | ||
| return self.start |
Member
Author
There was a problem hiding this comment.
I'm not hugely in love with this, might revisit it later to see if i can make it cleaner
Zylphrex
approved these changes
Jul 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75070 +/- ##
==========================================
- Coverage 78.12% 78.12% -0.01%
==========================================
Files 6748 6748
Lines 301209 301221 +12
Branches 51833 51838 +5
==========================================
+ Hits 235328 235329 +1
- Misses 59554 59562 +8
- Partials 6327 6330 +3
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.