feat(owners): Display code owners for events#7540
Merged
Merged
Conversation
billyvg
reviewed
Mar 9, 2018
| key={`${owner.id}:${owner.type}`} | ||
| className="avatar-grid-item tip" | ||
| onClick={() => this.assignToActor(owner)} | ||
| title={ReactDOMServer.renderToStaticMarkup( |
Contributor
Author
There was a problem hiding this comment.
is this that bad? better than building a string, right?
Contributor
Author
There was a problem hiding this comment.
it is gross that we send tooltips through bootstrap js
billyvg
approved these changes
Mar 9, 2018
billyvg
left a comment
billyvg
left a comment
Member
There was a problem hiding this comment.
Would be nice to have some tests (I'm ok if we do a follow up PR for the other fixes).
| render() { | ||
| if (!(this.state.owners && this.state.owners.length)) { | ||
| let {committers, owners} = this.state; | ||
| let showOwners = new Set(this.getOrganization().features).has('internal-catchall'); |
Member
There was a problem hiding this comment.
If you're gonna use a mixin, there's getFeatures
Contributor
Author
There was a problem hiding this comment.
I want to remove the mixins from this component moving forward
| </h6> | ||
| <div className="avatar-grid">{this.state.owners.map(this.renderCommitter)}</div> | ||
| {committers.length ? ( | ||
| <React.Fragment> |
Member
There was a problem hiding this comment.
Would be nice to refactor this into a method or component.
| <React.Fragment> | ||
| <h6> | ||
| <span>{t('Suggested Owners')}</span> | ||
| <small style={{background: '#FFFFFF'}}>Click to assign</small> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
display owners for event
hacky :/ this component should be using our async component pattern and using the tool tip component, but in the interest of getting this ready to dogfood asap I opened this. I'll improve it tomorrow