Skip to content

ref(control_silo): Move over Authenticator model to Users module#75857

Merged
Christinarlong merged 11 commits into
masterfrom
christinarlong/consolidate-users-models-authenticator
Aug 12, 2024
Merged

ref(control_silo): Move over Authenticator model to Users module#75857
Christinarlong merged 11 commits into
masterfrom
christinarlong/consolidate-users-models-authenticator

Conversation

@Christinarlong

@Christinarlong Christinarlong commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

Part of moving control silo user related resources into the users module. Includes adding of types for functions.

Apart of (#73856)

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 8, 2024

@markstory markstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👏

Comment thread src/sentry/models/__init__.py Outdated
Christinarlong and others added 2 commits August 8, 2024 12:58

@markstory markstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Christinarlong Christinarlong marked this pull request as ready for review August 12, 2024 18:22
@Christinarlong Christinarlong requested a review from a team August 12, 2024 18:22
@Christinarlong Christinarlong requested a review from a team as a code owner August 12, 2024 18:22
@Christinarlong Christinarlong requested a review from a team August 12, 2024 18:22
@Christinarlong Christinarlong requested review from a team as code owners August 12, 2024 18:22
@Christinarlong Christinarlong merged commit fa51081 into master Aug 12, 2024
@Christinarlong Christinarlong deleted the christinarlong/consolidate-users-models-authenticator branch August 12, 2024 19:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants