fix(incidents): Require non-null target_value for Discord #76553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise an InvalidTriggerActionError if the target_value is None. Modify test_discord_channel_id_none to assert for this error. (It appears that the test case's original intent was to test that the serializer doesn't crash, but the case where the target_value is None would inevitably cause an error anyway when we call `DiscordClient.get_channel`.)
Contributor
Author
github-actions
bot
added
the
Scope: Backend
Contributor
|
oh, I would just merge this into upstream directly -- that way we minimize the impact if this isn't correct |
Contributor
Author
👍 Done. |
Contributor
|
by upstream I mean integrate this to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an InvalidTriggerActionError if the target_value is None.
Modify test_discord_channel_id_none to assert for this error. (It appears that the test case's original intent was to test that the serializer doesn't crash, but the case where the target_value is None would inevitably cause an error anyway when we call
DiscordClient.get_channel.)