ref(ui): Have single interface for <Avatar>#7689
Merged
Merged
Conversation
billyvg
force-pushed
the
ref/ui/single-avatar-component
branch
from
8f083f7 to
a5ab548
Compare
billyvg
force-pushed
the
ref/ui/single-avatar-component
branch
from
8802688 to
6badee0
Compare
billyvg
force-pushed
the
ref/ui/single-avatar-component
branch
from
6badee0 to
020a107
Compare
Contributor
|
the tooltips for team avatars made through actorAvatar seem to not work |
Contributor
|
specifically, hasTooltip isn't being propogated all the way down into baseAvatar |
MaxBittker
approved these changes
Mar 23, 2018
Contributor
MaxBittker
left a comment
MaxBittker
left a comment
There was a problem hiding this comment.
great improvement, these were a pain to work with.
i tested them out in the places i could think to check and they worked well, except for the actorAvatar tooltips for teams.
billyvg
force-pushed
the
ref/ui/single-avatar-component
branch
from
f7319c8 to
e8190ff
Compare
billyvg
force-pushed
the
ref/ui/single-avatar-component
branch
from
daa9b57 to
013d40a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.