fix(tagstore): Override all delete methods to pass project_id#7697
Merged
Conversation
bretthoerner
force-pushed
the
override-tagstore-v2-deletes
branch
from
e3e3736 to
6486cf9
Compare
mattrobenolt
approved these changes
Mar 19, 2018
mattrobenolt
left a comment
mattrobenolt
left a comment
Contributor
There was a problem hiding this comment.
Yeah, this should be more than fine. We don't need signals or anything here for us.
🌭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we care about Django signals or anything on these... so override
deleteis probably OK? But need Django expert to weigh in here.