Skip to content

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Sep 9, 2024

WIP

This just adds the tests which I used to verify that this was the underlying problem. Passing the work off to the next triage rotation.

Also note that this issue only seems to apply for teams and not users, since the logic here checks for User instead of RpcUser when looking for existing owners.

@malwilley malwilley force-pushed the malwilley/fix/issue-owner-reordering branch from 2805689 to 274a4e4 Compare September 9, 2024 16:17
Copy link

codecov bot commented Sep 9, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
21498 1 21497 205
View the top 1 failed tests by shortest run time
tests.sentry.tasks.test_post_process.PostProcessGroupErrorTest test_owner_assignment_existing_owners_different_order
Stack Traces | 8.13s run time
#x1B[1m#x1B[.../sentry/tasks/test_post_process.py#x1B[0m:996: in test_owner_assignment_existing_owners_different_order
    assert assignee.team == new_assigned_team
#x1B[1m#x1B[31mE   AssertionError: assert <Team at 0x7f5a54b3cd10: id=4554671932702721, name='foo', slug='foo'> == <Team at 0x7f5a55552120: id=4554671932768256, name='Awake Honeybee', slug='awake-honeybee'>#x1B[0m
#x1B[1m#x1B[31mE    +  where <Team at 0x7f5a54b3cd10: id=4554671932702721, name='foo', slug='foo'> = <GroupAssignee at 0x7f5a54bdad50: id=36, group_id=632, user_id=None, team_id=4554671932702721>.team#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@malwilley malwilley closed this Sep 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant