Skip to content

Conversation

@RyanSkonnord
Copy link
Contributor

Remove unused parameters. Introduce AlertTarget as a consistent return type.

Remove unused parameters. Introduce AlertTarget as a consistent return
type.
@RyanSkonnord RyanSkonnord requested review from a team and asottile-sentry September 9, 2024 21:33
@RyanSkonnord RyanSkonnord requested a review from a team as a code owner September 9, 2024 21:33
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 9, 2024
@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/incidents/logic.py 83.92% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77201      +/-   ##
==========================================
- Coverage   78.16%   78.16%   -0.01%     
==========================================
  Files        6929     6930       +1     
  Lines      307731   307758      +27     
  Branches    50405    50410       +5     
==========================================
+ Hits       240547   240557      +10     
- Misses      60786    60795       +9     
- Partials     6398     6406       +8     

Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanSkonnord RyanSkonnord merged commit 48030e1 into master Sep 10, 2024
@RyanSkonnord RyanSkonnord deleted the incidents-logic-refactor-alert-targets branch September 10, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants