ref(grouping): Remove CalculatedHashes#77426
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
armenzg
force-pushed
the
deprecate/hierarchical_hashes/grouping/armenzg
branch
from
deef67b to
6874484
Compare
armenzg
commented
Sep 16, 2024
| Job = MutableMapping[str, Any] | ||
|
|
||
|
|
||
| def extract_hashes(calculated_hashes: CalculatedHashes | None) -> list[str]: |
| event.data["grouping_config"] = get_grouping_config_dict_for_project(project) | ||
| hashes = event.get_hashes() | ||
|
|
||
| hashes.write_to_event(event.data) |
Member
Author
There was a problem hiding this comment.
get_hashes() now takes care of writing to the event:
armenzg
force-pushed
the
deprecate/hierarchical_hashes/grouping/armenzg
branch
from
c6ad8e8 to
6dbfd1e
Compare
JoshFerge
reviewed
Sep 17, 2024
| # We don't set a combo `variants` value here because one set of variants would/could | ||
| # partially or fully overwrite the other (it's a dictionary), and having variants from two | ||
| # different configs all mixed in together makes no sense. | ||
| return ( |
Member
There was a problem hiding this comment.
is it necessary to return the third combined item here? can the callers just concatenate them?
Member
Author
There was a problem hiding this comment.
Good point. I will look into it.
JoshFerge
approved these changes
Sep 17, 2024
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
makes sense to me. might be good for @lobsterkatie to take a look as well.
Member
Author
@JoshFerge ugh. Want me to revert? Or wait to hear back? |
Member
|
@armenzg i think you're fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code originally added in #26740