fix(rdap): Use hostname from url #77788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/fix-rdap-use-hostname-from-url
branch
from
963776d to
8807b4d
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77788 +/- ##
===========================================
+ Coverage 51.05% 78.09% +27.03%
===========================================
Files 6957 6988 +31
Lines 308456 309851 +1395
Branches 50493 50699 +206
===========================================
+ Hits 157490 241966 +84476
+ Misses 149706 61412 -88294
- Partials 1260 6473 +5213 |
Instead of attempting to reconstruct the hostname from the url_domain
and url_domain_suffix use urlprase to extract the hostname.
The url_domain{,_suffix} are used for different de-duping reasons.
evanpurkhiser
force-pushed
the
evanpurkhiser/fix-rdap-use-hostname-from-url
branch
from
8807b4d to
080ff76
Compare
wedamija
approved these changes
Sep 19, 2024
evanpurkhiser
deleted the
evanpurkhiser/fix-rdap-use-hostname-from-url
branch
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
Instead of attempting to reconstruct the hostname from the url_domain
and url_domain_suffix use urlprase to extract the hostname.
The url_domain{,_suffix} are used for different de-duping reasons.
roaga
pushed a commit
that referenced
this pull request
Sep 20, 2024
Instead of attempting to reconstruct the hostname from the url_domain
and url_domain_suffix use urlprase to extract the hostname.
The url_domain{,_suffix} are used for different de-duping reasons.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of attempting to reconstruct the hostname from the url_domain and url_domain_suffix use urlprase to extract the hostname.
The url_domain{,_suffix} are used for different de-duping reasons.