chore(deps): Upgrade Sentry Python SDK to 2.16.0 #78998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version comes with Brotli compression and HTTP2Transport which are enabled as part of this patch.
github-actions
bot
added
the
Scope: Backend
sentrivana
approved these changes
Oct 11, 2024
src/sentry/utils/sdk.py
Outdated
Comment on lines
283
to
285
| sdk_options.setdefault("_experiments", {}).update( | ||
| transport_http2=True, | ||
| ) |
Contributor
There was a problem hiding this comment.
just to minimize risk a bit -- should the upgrade and enabling this be two separate patches? (would also allow fast reverting one without the other if it goes poorly)
Member
Author
There was a problem hiding this comment.
Yeah, makes sense. I was actually hoping to trigger this with a feature flag but not sure if that makes sense.
Will update this to not have http2 turned on.
asottile-sentry
added
the
Trigger: getsentry tests
victoria-yining-huang
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit 6b158e8.
asottile-sentry
added
the
Trigger: Revert
Contributor
|
PR reverted: cccaf96 |
getsentry-bot
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit 6b158e8. Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
Contributor
|
reverting as this broke the development environment: |
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
This version comes with Brotli compression and HTTP2Transport which are enabled as part of this patch. We already have `httpcore>=1.*` and `Brotli` as part of our dependencies so no changes needed in this patch regarding getting these installed.
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
This reverts commit 6b158e8. Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version comes with Brotli compression and HTTP2Transport which are enabled as part of this patch.
We already have
httpcore>=1.*andBrotlias part of our dependencies so no changes needed in this patch regarding getting these installed.