feat(dynamic-sampling): adding org option for target sample rate #79090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Member
|
Can you also add a test that would check that this options is returned from the endpoint? Some of the existing tests can be extended in: |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79090 +/- ##
==========================================
- Coverage 78.34% 78.32% -0.03%
==========================================
Files 7125 7134 +9
Lines 314477 314243 -234
Branches 51356 51308 -48
==========================================
- Hits 246384 246117 -267
- Misses 61650 61681 +31
- Partials 6443 6445 +2 |
add tests for range validation
constantinius
deleted the
constantinius/feat/org-option-target-sample-rate
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getsentry/projects/issues/203
Adds new org level option for
"targetSampleRate"/"sentry:target_sample_rate"with a default value from the constantTARGET_SAMPLE_RATE_DEFAULT.