ref(grouping): Improve representation of grouping objects #79231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79231 +/- ##
==========================================
- Coverage 78.38% 78.38% -0.01%
==========================================
Files 7140 7140
Lines 315440 315440
Branches 51550 51550
==========================================
- Hits 247261 247250 -11
- Misses 61711 61716 +5
- Partials 6468 6474 +6 |
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
141fc21 to
bdb65ac
Compare
lobsterkatie
force-pushed
the
kmclb-use-full-save-pipeline-for-new-config-variant-tests
branch
from
c839f6e to
cee9d5e
Compare
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
bdb65ac to
07ccd18
Compare
lobsterkatie
force-pushed
the
kmclb-use-full-save-pipeline-for-new-config-variant-tests
branch
from
cee9d5e to
da286ec
Compare
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
07ccd18 to
d289ede
Compare
lobsterkatie
force-pushed
the
kmclb-use-full-save-pipeline-for-new-config-variant-tests
branch
from
da286ec to
e1caa35
Compare
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
d289ede to
d3d8838
Compare
lobsterkatie
force-pushed
the
kmclb-use-full-save-pipeline-for-new-config-variant-tests
branch
from
e1caa35 to
2717d77
Compare
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
d3d8838 to
0388a5c
Compare
lobsterkatie
force-pushed
the
kmclb-use-full-save-pipeline-for-new-config-variant-tests
branch
from
2717d77 to
700a107
Compare
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
0388a5c to
8d0e496
Compare
lobsterkatie
force-pushed
the
kmclb-use-full-save-pipeline-for-new-config-variant-tests
branch
from
700a107 to
df1a172
Compare
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
8d0e496 to
f681cf4
Compare
Base automatically changed from
kmclb-use-full-save-pipeline-for-new-config-variant-tests
to
master
October 22, 2024 14:30
An error occurred while trying to automatically change base from
kmclb-use-full-save-pipeline-for-new-config-variant-tests
to
master
October 22, 2024 14:30
lobsterkatie
force-pushed
the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
from
f681cf4 to
ef18d3e
Compare
armenzg
approved these changes
Oct 22, 2024
lobsterkatie
deleted the
kmclb-improve-grouping-component-and-fingerprinting-rule-json
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
This makes two small changes to the way objects used in our grouping algorithm represent and then eventually jsonify themselves. - For `GroupingComponent.description`, fall back to the `id` value rather than using the generic value `"others"`. - Add the original text of a fingerprinting rule to its dictified version. This results in a more human-readable way to display which rule matched a given event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two small changes to the way objects used in our grouping algorithm represent and then eventually jsonify themselves.
GroupingComponent.description, fall back to theidvalue rather than using the generic value"others".