Skip to content

Conversation

@gggritso
Copy link
Member

@gggritso gggritso commented Oct 16, 2024

Didn't want to lose this feature from the current implementation.

e.g.,
Screenshot 2024-10-16 at 5 17 42 PM

No need to pass the whole `tableData` object since the work to extract
the data type is done in the parent component.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ildSteps/thresholdsStep/thresholdsHoverWrapper.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #79240   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files        7123     7122    -1     
  Lines      314393   314364   -29     
  Branches    51345    51342    -3     
=======================================
- Hits       246274   246264   -10     
+ Misses      61674    61655   -19     
  Partials     6445     6445           

@gggritso gggritso marked this pull request as ready for review October 16, 2024 21:57
@gggritso gggritso requested a review from a team October 16, 2024 21:57
Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gggritso gggritso merged commit c122518 into master Oct 17, 2024
47 checks passed
@gggritso gggritso deleted the feat/dashboards/big-number-widget-thresholds-tooltip branch October 17, 2024 13:55
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
Didn't want to lose this feature from the current implementation.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants