feat(issues): Redesign streamline event nav #79656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79656 +/- ##
==========================================
- Coverage 78.46% 78.45% -0.02%
==========================================
Files 7146 7148 +2
Lines 316027 316085 +58
Branches 43486 43498 +12
==========================================
+ Hits 247966 247979 +13
- Misses 61730 61771 +41
- Partials 6331 6335 +4 |
scttcper
commented
Oct 24, 2024
Comment on lines
+34
to
+37
| /** | ||
| * Disable tabs from being put in the overflow menu. | ||
| */ | ||
| disableOverflow?: boolean; |
Member
Author
There was a problem hiding this comment.
displaying tabs in flex/grid really gets annoying if the flex isn't set to grow. needed the option to just disable overflow
annoying overflow for no reason
# Conflicts: # static/app/views/issueDetails/groupEventDetails/groupEventDetails.tsx # static/app/views/issueDetails/streamline/eventDetails.tsx
leeandher
approved these changes
Oct 24, 2024
Member
leeandher
left a comment
leeandher
left a comment
There was a problem hiding this comment.
Broadly looks good, everything seems functional, but those drawers are gonna get some comments. Happy to help with rebuilding the page views for the sections
Member
There was a problem hiding this comment.
Margin with the issue summary is a bit large at the moment, though not sure this matters since it's moving soon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not being done in this already big pr: